Sign up for github. Go to this page https://github.com/sympy/sympy/pull/1319 Join the discussion at the bottom Press the "Diff" button at the top and carefully look through the changes that have been made. You can make comments in line as well (I find this very helpful.)
I actually really like GitHub's interface for code review. I've been toying with the idea of using it in a classroom setting... On Fri, Jun 15, 2012 at 8:12 AM, David Joyner <[email protected]> wrote: > On Fri, Jun 15, 2012 at 9:06 AM, Aleksandar Makelov > <[email protected]> wrote: > > Hi all, > > > > Time flies and my work on computational group theory is not yet being > merged > > to sympy, so I'm starting to get worried. > > > > So, would anyone enjoy reviewing some of it? I currently have the > following > > I'd be happy to help but I am not sure what is involved in a review. > I can get the code, read the code, and run tests. > What is involved in a review? Just sign in to github and post a comment > "positive review"? > > > publicly available code: one open pull request located here: > > https://github.com/sympy/sympy/pull/1319 > > and some more code waiting on my local branch week2: > > https://github.com/amakelov/sympy/tree/week2 > > > > Also, there is an implementation of a randomized Schreier-Sims algorithm > > along with some other minor additions (see here: > > > http://amakelov.wordpress.com/2012/06/10/google-summer-of-code-2012-week-3/ > > ) which is not yet pushed to my fork, if anyone's interested. > > > > The main resource I'm using is > > Holt, D., Eick, B., O’Brien, E. “Handbook of computational group theory” > > > > If you're working on something that requires some nontrivial mathematical > > background for review, I'd be happy to help you in turn. :) > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy" group. > > To view this discussion on the web visit > > https://groups.google.com/d/msg/sympy/-/bdG8bZGxsw0J. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]. > > For more options, visit this group at > > http://groups.google.com/group/sympy?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
