Checkout his branch on your computer cd doc make html cd _build/html On Fri, Jun 15, 2012 at 9:07 AM, David Joyner <[email protected]> wrote:
> Thanks Matthew and Sergiu for the github help! > > I have some general comments and specific comments. > > The specific comments all pertain to methods in the permutation > module which I guess were written by someone else and basically > are all questions I have about the docstrings. > > The general comment, which is really a design issue > more than anything else, is that I like the module structure laid > out in Sage: > http://www.sagemath.org/doc/reference/groups.html > There is a separate module for all the "named" permutation > groups (eg, the AlternatingGroup), of which there are 16 listed > there. I am afraid that the perm_group module will get too > huge quickly without some thought to a more modular > structure. BTW, I wrote the sage module permgroup_named.py, > > http://www.sagemath.org/doc/reference/sage/groups/perm_gps/permgroup_named.html > , > and please feel free to take all you want and relicense it BSD > with my permission. > > I would also recommend splitting off permutation group homomorphisms, > once you write them, into another module. > > About the code you have written, you've done good work on the > documentation. How do I test how the docstrings will > render when they get processed for the sympy manual > http://docs.sympy.org/0.7.1/index.html ? I would like to see how the > html renders, if possible, before making more comments. > > > On Fri, Jun 15, 2012 at 9:19 AM, Sergiu Ivanov > <[email protected]> wrote: > > Hello, > > > > On Fri, Jun 15, 2012 at 4:12 PM, David Joyner <[email protected]> > wrote: > >> > >> I'd be happy to help but I am not sure what is involved in a review. > >> I can get the code, read the code, and run tests. > >> What is involved in a review? Just sign in to github and post a comment > >> "positive review"? > > > > That's almost all correct :-) > > > > You should sign in to GitHub and follow one of the links Aleksandar > > has provided. There you will be able to view the commits on the > > branch from which the pull request has been submitted (you will see a > > button Commits). You will also be able to see how the latest version > > of the code in the branch looks (Diff page). When you mouse over the > > line number in the code view window, you will see a small button which > > allow you to post a comment to a certain line of code. Thus, > > "reviewing" means commenting on certain pieces of code with the goal > > of correcting some mistakes, typos. You will also be able to leave > > comments to the whole pull request on the Discussion page. > > > > Sergiu > > > > -- > > You received this message because you are subscribed to the Google > Groups "sympy" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > [email protected]. > > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
