Hello, On Fri, Jun 15, 2012 at 4:12 PM, David Joyner <[email protected]> wrote: > > I'd be happy to help but I am not sure what is involved in a review. > I can get the code, read the code, and run tests. > What is involved in a review? Just sign in to github and post a comment > "positive review"?
That's almost all correct :-) You should sign in to GitHub and follow one of the links Aleksandar has provided. There you will be able to view the commits on the branch from which the pull request has been submitted (you will see a button Commits). You will also be able to see how the latest version of the code in the branch looks (Diff page). When you mouse over the line number in the code view window, you will see a small button which allow you to post a comment to a certain line of code. Thus, "reviewing" means commenting on certain pieces of code with the goal of correcting some mistakes, typos. You will also be able to leave comments to the whole pull request on the Discussion page. Sergiu -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
