On Sat, Jul 20, 2013 at 12:37 PM, Ondřej Čertík <[email protected]> wrote:
> On Sat, Jul 20, 2013 at 12:27 PM, Mary Clark <[email protected]>
> wrote:
>>
>> Here is the output of git status:
>>
>> (null):sympy maryclark$ git status
>> # On branch liealgebras_1
>> # Changes not staged for commit:
>> # (use "git add <file>..." to update what will be committed)
>> # (use "git checkout -- <file>..." to discard changes in working
>> directory)
>> #
>> # modified: sympy/liealgebras/cartan_type.py
>> #
>> # Untracked files:
>> # (use "git add <file>..." to include in what will be committed)
>> #
>> # planet.sympy.org/
>> # sympy/liealgebras/cartan_matrix.py
>> # sympy/liealgebras/tests/test_cartan_type.py
>> no changes added to commit (use "git add" and/or "git commit -a")
>>
>> Just for the record, the file on my computer is named test_type_A.py. I am
>> uncertain why when I run the tests it shows up as test_type_a.py.
>
> Indeed, interesting. So do the following:
>
> git checkout -b work
> git add sympy/liealgebras/cartan_matrix.py
> sympy/liealgebras/tests/test_cartan_type.py
> git commit
>
> This will commit the two untracked files into a new branch called
> "work". You can get to them later. Then:
>
> git checkout liealgebras_1
>
> This goes back to your original branch. Do:
>
> git status # should not show any untracked Python files
> git diff # should only show your print statement
>
> Try to run the tests again:
>
> ./bin/test sympy/liealgebras
>
> now it should only run one test. So at least this part will get
> resolved. I expect that it will pass for you, but let's just make
> sure.
>
> Then we'll go from there. If we cannot make it behave the same on your
> computer, I can always fix it myself, but I just want to make sure
> that you can reproduce the failures --- things should not behave
> differently on your computer versus Travis or my computer, unless
> there is something fishy going on.
So on my machine, this patch fixes the test:
ondrej@eagle:~/repos/sympy(liealgebras_1)$ git diff
diff --git a/sympy/liealgebras/cartan_type.py b/sympy/liealgebras/cartan_type.py
index 696711a..80e8eca 100644
--- a/sympy/liealgebras/cartan_type.py
+++ b/sympy/liealgebras/cartan_type.py
@@ -14,7 +14,7 @@ def __call__(self, *args):
if letter == "A":
if n >= 0:
import type_A
- return type_A.CartanType(n)
+ return type_A.TypeA(n)
if letter == "B":
if n >= 0:
import type_B
Can you look into your cartan_type.py and make sure that only your
print statement is in there? Maybe you also fixed this line and that's
why it works for you and you missed this change in the "git diff"
output.
Ondrej
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
For more options, visit https://groups.google.com/groups/opt_out.
