On Sat, Jul 20, 2013 at 1:09 PM, Ondřej Čertík <[email protected]> wrote: > On Sat, Jul 20, 2013 at 12:58 PM, Mary Clark <[email protected]> > wrote: >> Okay, I have done all the things that you said. My tests pass. >> >> In cartan_type, I do have: >> >> >> if letter == "A": >> if n >= 0: >> import type_A >> return type_A.TypeA(n) >> >> so, I did miss that in the git diff output. My apologies. I suppose this >> is why the test works for me! Sorry for missing that prior. >> I suppose, however, that this does not solve the whole problem with the >> doctest failing? > > So then commit this particular change, push it to github. This should > fix all the tests failing.
You can do that by: git add -p and select only the chunk that you want to commit. O. > > Now, to investigate doctests failing, just do: > > ondrej@eagle:~/repos/sympy(liealgebras_1)$ bin/doctest sympy/liealgebras/ > ============================= test process starts > ============================== > executable: /usr/bin/python (2.7.3-final-0) [CPython] > architecture: 64-bit > cache: yes > ground types: python > hash randomization: on (PYTHONHASHSEED=2329935778) > > sympy/liealgebras/type_A.py[3] .F. > [FAIL] > > ________________________________________________________________________________ > __________________ sympy.liealgebras.type_A.TypeA.simple_root > __________________ > File "sympy/liealgebras/type_A.py", line 54, in > sympy.liealgebras.type_A.TypeA.simple_root > Failed example: > c.simple_root(1) > Expected: > [1,-1,0,0,0] > Got: > [1, -1, 0, 0, 0] > > ============= tests finished: 2 passed, 1 failed, in 0.02 seconds > ============== > DO *NOT* COMMIT! > > > On my computer, I am just getting some simple error due to whitespace > --- just put spaces around "," and that should do it. Let me know what > you get when you run doctests. > > > Ondrej > > P.S. I am sorry you had to go through all these troubles. But you > learned some new things about git and in the next pull request things > will go much faster. > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at http://groups.google.com/group/sympy. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
