On Fri, Jan 23, 2015 at 12:28 PM, Joachim Durchholz <[email protected]> wrote: > Am 23.01.2015 um 16:22 schrieb Ondřej Čertík: > >> On Fri, Jan 23, 2015 at 3:34 AM, Joachim Durchholz <[email protected]> >> wrote: >>> >>> Am 23.01.2015 um 07:29 schrieb Jason Moore: >>>> >>>> >>>> This is timely: >>>> >>>> https://github.com/blog/1943-how-to-write-the-perfect-pull-request >>> >>> >>> >>> That's an excellent list. Concise and to the point, but all the important >>> things covered (including some I wasn't aware of except subconsciously, >>> good >>> to have that explict). >>> >>>> Looks like Github had to clarify communication guidelines for their >>>> company >>>> in an explicit way. Worth a read. >>> >>> >>> >>> Worth linking from our github instructions page IMHO. >>> Opinions? >> >> >> You are welcome to put it into the wiki. > > > That was the plan, I just wanted to know whether others liked it well enough > to have it linked :-) > > ... done. Added two paragraphs at the end of > https://github.com/sympy/sympy/wiki/Development-workflow#reviewing-patches .
Looks good to me. Thanks! Ondrej > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/54C2A0E9.90805%40durchholz.org. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVBn239av%3DWKfjO5pgkYf%3D2BJQKXTYLPhs9vWALyB%3D%3D0Gw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
