On Tue, Jun 9, 2015 at 4:25 PM, Joachim Durchholz <[email protected]> wrote: > Am 09.06.2015 um 23:55 schrieb Jason Moore: >> >> I don't think Github cares how we manage our projects. > > > Sort of. There is a "GitHub workflow", and not all git workflows are easily > mappable to it (git-flow, for example, won't - not easily anyway). > > Though I agree that they probably don't care about labels. > >> This is only about >> >> enabling us to manage it how we want/need. If they have a checkbox in the >> repo's settings that allows/disallows PR authors to modify labels then we >> can decide how much freedom we want to give an author. > > > It would need to be settable on a per-label basis. > We want some labels to be settable only by people who can merge, and some > labels settable by everyone. Similarly for resetting. > > Examples: > > We don't want "ready to merge if Travis is okay" to be settable by > everybody, we want to reserve that for those who can actually do a merge. > However, we want to allow the PR author and any reviewer to remove it.
First of all, we can trust the PR authors with stuff like this. The one how does the actual merge must review the PR anyway (since he is ultimately responsible), and see who set what labels. So if the PR author is trying to deceive us, we would found out anyway. Second, in my workflow, I propose only two labels (author's turn / sympy's turn). You can post a comment that you are ok with merging this if tests pass. Ondrej > > For the "needs more work" label, reviewers and the PR author should be able > to set and to remove it. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/557767DB.1000903%40durchholz.org. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVCdCGAR58xg5KucO7RSku1EOfraRVQOfv0jaCHXHAoa8w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
