Am 10.06.2015 um 00:34 schrieb Ondřej Čertík:
We don't want "ready to merge if Travis is okay" to be settable by
everybody, we want to reserve that for those who can actually do a merge.
However, we want to allow the PR author and any reviewer to remove it.
First of all, we can trust the PR authors with stuff like this.
I'm more worried about mistakes than about intentional deception.
(Oh and then there's trolling, but trolls get banned eventually.)
> The
one how does the actual merge must review the PR anyway (since he is
ultimately responsible), and see who set what labels. So if the PR
author is trying to deceive us, we would found out anyway.
Having to check that will be additional work.
Though... probably unavoidable, the author could have added more commits
before Travis finishes, so "okay to merge after Travis success" is
probably not that useful, I guess such status labels would need to be
removed with every update to the PR.
Second, in my workflow, I propose only two labels (author's turn /
sympy's turn). You can post a comment that you are ok with merging
this if tests pass.
You're right - I thought each should be settable only by one party and
resettable by the other, but after some more thinking, I see that both
PR author and SymPy PR gatekeepers need to set and reset both labels.
Still, I do see use cases for per-label configuration.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sympy/5577F135.4000400%40durchholz.org.
For more options, visit https://groups.google.com/d/optout.
