Am Mittwoch 02 November 2005 10:47 schrieb Sergio CERLESI:
> There is another bug fixed from these patchs, if rra_contact_from_vcard
> tries to parse a vcard with two or more fields of the same type (for
> example four mobile phones) it creates an object with four entries and
> the contact on my ipaq contain the last value and some dirty fields.
> With these patches it considers only the first value of any type:
>
> if (propval->propid & CEVT_FLAG_EMPTY)
> {
>       ...
> }
>
> I'm waiting to know if there is something to change into these patch.

Hm, this bug is already fixed (workarounded), at least for tel_work, tel_home 
and email.
All of these values are queued, because there might be one or more preferred 
ones.
These will be taken first, converted to the correct IDs and if there is space 
left, the remaining ones are considered:

http://sourceforge.net/mailarchive/message.php?msg_id=11585570
http://sourceforge.net/mailarchive/message.php?msg_id=11677884

CVS is already patched.
You know, that you have the patched sources, if your contact_ids.h contains:
----------------------
#define MAX_TEL_WORK 2
#define MAX_TEL_HOME 2
#define MAX_EMAIL 3
----------------------

Your patch skips all except the first, I don't think that this is a good idea, 
because 
1) there is more than 1 slot on the device

2) and this is even more important
the information of the remaining fields will be lost when syncing back from 
device to local if the contact got modified on the device.

Please divide the patch into 2 patches, so that the fixes can be applied 
separatly

rgds
-- 
 e-Trolley Sayegh & John, Nabil Sayegh
 Tel.: 0700 etrolley /// 0700 38765539
 Fax.: +49 69 8299381-8
 PGP : www.e-trolley.de

-- 
 e-Trolley Sayegh & John, Nabil Sayegh
 Tel.: 0700 etrolley /// 0700 38765539
 Fax.: +49 69 8299381-8
 PGP : www.e-trolley.de


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Synce-devel mailing list
Synce-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synce-devel

Reply via email to