Hi,
I send this email without attached file because the original email are
reject for size reason. The attached file was send only to Nabil.
Original email:
-----------------------------------------------------------------------
Hi,
the bug of which I said is another, I know that tel_work, tel_home and
email are handles but not others type for example "TYPE=CELL". With
Evolution (for example) is possible to create a vcard with more that one
"TYPE=CELL" and thit is not handle.
My patch "skips all except the first" for any propid
"if (propval->propid & CEVT_FLAG_EMPTY)"
but prodid of ID_EMAIL are different to prodid of ID_EMAIL2 or, prodid
of ID_WORK_TEL are different to prodid of ID_WORK2_TEL so, ID_EMAIL2 are
not skip if there is an ID_EMAIL but only if there is another ID_EMAIL2.
My patch works jointly with the workaround.
I attached a vcard that I used for my test and two image of the
correspondent contact creates into my ipaq (i used the last cvs version
of rra with the workaround that you said) one before my patch and one
after.
For divide my patch into 2 there is no problem, only which of two
patches I posted (synce-rra-0.9.1-vcard-empty-fields.1.diff or
synce-rra-0.9.1-vcard-empty-fields.2.diff) ?
If you have any dubs don't hesitated to write me.
---------------------------------------------------------------------------
Regards
Sergio
Il giorno gio, 03/11/2005 alle 21.30 +0100, Nabil Sayegh ha scritto:
> Am Mittwoch 02 November 2005 10:47 schrieb Sergio CERLESI:
> > There is another bug fixed from these patchs, if rra_contact_from_vcard
> > tries to parse a vcard with two or more fields of the same type (for
> > example four mobile phones) it creates an object with four entries and
> > the contact on my ipaq contain the last value and some dirty fields.
> > With these patches it considers only the first value of any type:
> >
> > if (propval->propid & CEVT_FLAG_EMPTY)
> > {
> > ...
> > }
> >
> > I'm waiting to know if there is something to change into these patch.
>
> Hm, this bug is already fixed (workarounded), at least for tel_work, tel_home
> and email.
> All of these values are queued, because there might be one or more preferred
> ones.
> These will be taken first, converted to the correct IDs and if there is space
> left, the remaining ones are considered:
>
> http://sourceforge.net/mailarchive/message.php?msg_id=11585570
> http://sourceforge.net/mailarchive/message.php?msg_id=11677884
>
> CVS is already patched.
> You know, that you have the patched sources, if your contact_ids.h contains:
> ----------------------
> #define MAX_TEL_WORK 2
> #define MAX_TEL_HOME 2
> #define MAX_EMAIL 3
> ----------------------
>
> Your patch skips all except the first, I don't think that this is a good
> idea,
> because
> 1) there is more than 1 slot on the device
>
> 2) and this is even more important
> the information of the remaining fields will be lost when syncing back from
> device to local if the contact got modified on the device.
>
> Please divide the patch into 2 patches, so that the fixes can be applied
> separatly
>
> rgds
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Synce-devel mailing list
Synce-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synce-devel
