On Wed, 2008-05-21 at 16:38 +0100, Dr J A Gow wrote:
> 
> On Wed, 2008-05-21 at 11:24 +0100, Mark Ellis wrote:
> 
> > John, I'm attaching a patch for you. I would've committed it myself but
> > I'm still not that familiar with most of sync-engine, so thought it best
> > that you had a look.
> > 
> > 1) installs config.xml into sys.prefix/share/doc/sync-engine
> > 
> > 2) doesn't copy the file
> > 
> > 3) Reads the system config file first, which is expected to be in /etc
> > if sys.prefix is /usr, or sys.prefix/etc otherwise, then reads the user
> > file
> > 
> 
> The patch seems basically OK from looking at it. I'm not going to get a
> chance to check it physically until tomorrow night - can you try one
> thing? Just delete the entirety of ~/.synce, not just its contents. Then
> see if it gets correctly recreated when sync-engine is run and new
> partnerships are created.
> 
> Reason is that you have removed the line that creates config_dir. Now I
> can't remember whether the partnership code will also create it without
> looking at the code, and I have a feeling it may fail when no ~/.synce
> exists.
> 

Partnership.__init__ checks to see if the partnerships dir exists, and
if not does an os.makedirs(), which is recursive, on the full path,
looks fine.

> I will submit it to a more thorough evaluation tomorrow if you can wait
> that long :)
> 
>       John.
> 
> 

Cool, I'm not going anywhere :)

Attachment: signature.asc
Description: This is a digitally signed message part

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synce-devel

Reply via email to