http://bugs.meego.com/show_bug.cgi?id=1197
--- Comment #14 from pohly <[email protected]> 2010-04-24 04:59:41 PDT --- (In reply to comment #12) > > - check whether we can get the correct config without adding tests > > > > Congwu, does the following logic work: > > - if normal testing of "calendar" and "todo" finds the same URI, > > conclude that they have to be combined > > - if the URI is different, no need to combine; we can avoid false > > positives by testing the self.uris['calendar'] after the ones > > specific to "todo" > > I have implemented this, but wasn't able to test with a device which actually > combines events and tasks. After thinking some more about this, I think the current version of the script will fail to detect combined calendar+todo for Nokias, because of the changed order of URIs that we test. I think Nokia phones ignore the URI that we send to it and then decides on the data store entirely based on the data type. That way the first URIs for calendar and todo are accepted ("Calendar" and "Task"), which breaks the "URI equal" comparison. The fix should be simple - test the calendar URIs first when testing todos, as it was done before my last commit: diff --git a/test/syncevo-phone-config.py b/test/syncevo-phone-config.py index 3f93458..38d7cc6 100755 --- a/test/syncevo-phone-config.py +++ b/test/syncevo-phone-config.py @@ -350,7 +350,7 @@ class TestingConfiguration(): self.uris = {} self.uris['addressbook'] = ['Contact', 'contact', 'Contacts', 'contacts', 'Addressbook', 'addressbook'] self.uris['calendar'] = ['Calendar', 'calendar', 'Agenda','agenda'] - self.uris['todo'] = ['Task', 'task', 'Tasks', 'tasks', 'Todo','todo'] + self.uris['calendar'] + self.uris['todo'] = self.uris['calendar'] + ['Task', 'task', 'Tasks', 'tasks', 'Todo','todo'] self.uris['memo'] = ['Memo', 'memo', 'Notes', 'notes', 'Note', 'note'] if (types): I've put that into the git branch. -- Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
