http://bugs.meego.com/show_bug.cgi?id=1197

--- Comment #15 from congwu <[email protected]> 2010-04-25 19:05:33 PDT ---
One typo: allContacts-> allSources
-if options.source and options.source not in allContacts:
-    parser.error("Option -s/--source can only be one of " +
"|".join(allContacts) + ".")
+if options.source and options.source not in allSources:
+    parser.error("Option -s/--source can only be one of " +
"|".join(allSources) + ".")


Regarding the newly implemented combined calendar+todo test, I agree testing
calendar and todo separately and then checking URI equalness is a good hint for
most cases, but I am not entirely sure whether it works reliably.

The first concern is does calendar and todo has the same URI will always mean
they are combined? I think there is at least one slightly difference between
the two:
combined means not only same URI but also same type, while it might be possible
that the phone has calendar and todo with the same URI but different types.

The second concern is does testing possible calendar URIs for Calendar and
calendar URIs + todo URIs for Todo works? Is it possible that the phone has a
combined calendar+task and has the URI named as 'todo'? In other words, I think
both calendar and todo has to test with all possible URIs for calendar and todo
(which means test cases were not effectively reduced but increased actually).

-- 
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
_______________________________________________
Syncevolution-issues mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution-issues

Reply via email to