Hello!

I found another dependency of the tests on the host setup: the default
backend had to have suitable databases configured. Test failures in the
nightly testing were the result. For example:
http://runtests.syncevolution.org/2011-07-03-21-30_all/head-lucid-i386/nightly.html
http://runtests.syncevolution.org/2011-07-03-21-30_all/head-lucid-i386/6-dbus/SessionAPIsDummy_CheckSource.log

Instead of documenting this and changing the nightly test setup, I
removed this dependency. I also merged the patch for avoiding the
"test-dbus" name clash, albeit changed the name once more because I
preferred a different name. See master branch:


commit 3d461623d046293931578f79dc9eaf04fc6f81d3
Author: Patrick Ohly <[email protected]>
Date:   Mon Jul 4 17:18:58 2011 +0200

    D-Bus testing: fixed wrong check in TestConnection.testStartSync
    
    The test checked for zero status for inactive sources, whereas the
    current implementation doesn't report anything for these sources at
    all. Both is acceptable, but let's keep the test strict and check for
    the current behavior.

commit be08788419c69abe7833919dd5084481c4c9b88c
Author: Patrick Ohly <[email protected]>
Date:   Mon Jul 4 17:10:41 2011 +0200

    D-Bus testing: avoid dependency on default backend and its databases
    
    TestConnection and TestSessionAPIsDummy used configs with
    backend=addressbook/calendar/todo/memo which had to have databases
    with a name derived from CLIENT_TEST_EVOLUTION_SOURCE and the source
    name. This was neither documented nor did the required databases match
    the ones used by the client-test programs anymore.
    
    For the sake of making the test setup easier, this commit changes
    these tests so that they use the file backend (always available) and
    file://temp-test-dbus/<source name> databases (created if needed by
    the backend). In other words, the tests now run without manual setup
    of the host.
    
    The downside is that D-Bus testing no longer covers the real
    sources. That's okay, client-test covers that, whereas test-dbus.py
    should focus on the D-Bus API itself.

commit 32c78d4d8138c04b755e6075725b126e62dea8c3
Author: Patrick Ohly <[email protected]>
Date:   Mon Jun 27 15:55:49 2011 +0200

    D-Bus testing: use 'temp-test-dbus' as name of directory created for testing
    
    'temp-test-dbus' is a bit more suitable than 'xdg-root' because
    * it ties the directory to the script which creates it
    * 'temp' implies that it holds no important data
    * it is used for various files ('xdg_root' in the Python source
      is a bit misleading)

commit 8933a5959596ccaa2cc02ff1ee9b6d62f4197673
Author: Chris Kühl <[email protected]>
Date:   Mon Jun 27 15:55:49 2011 +0200

    test-dbus: Change default fr xdg_root
    
    The default value of 'test-dbus' is the same name as the directory
    holding the source files used for testing. In the DBusUtil.runTest the
    xdg_root directory is removed. So, when running test-dbus-py from the
    test directory it deletes the directory in which the source file
    reside.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.


_______________________________________________
SyncEvolution mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution

Reply via email to