On Mon, Jul 4, 2011 at 10:03 PM, Patrick Ohly <[email protected]> wrote: > On Wed, 2011-06-29 at 15:58 -0700, Patrick Ohly wrote: >> FAIL: a second session should not run unless the first one stops >> AssertionError: >> ['session /org/syncevolution/Session/12604096081309383605 idle', >> 'session /org/syncevolution/Session/2552452311309383604 done'] != >> ['session /org/syncevolution/Session/12604096081309383605 idle', >> 'session /org/syncevolution/Session/12604096081309383605 ready', >> 'session /org/syncevolution/Session/2552452311309383604 done'] >> "Ready" before "Done"? Might be harmless, need to check. > > Seems to occur only when running all tests. A bit mysterious, > syncevo-dbus-server should be restarted for each test. > > Perhaps this has something to do with the mock net.connman.Manager > implementation that some of the tests created on the D-Bus session bus. > I saw some "TypeError: 'NoneType' object is not iterable" errors caused > by it, because its GetProperties() method doesn't have a final "else" > clause and just returns without value. Will look further. > >> FAIL: Executes a real sync with no corresponding config. >> AssertionError: dbus.UInt32(500L) != 10500 >> "No such config" should be a local error, not a remote one. Must be >> fixed in syncevo-dbus-server. > > commit cb9b7c3e2b3ac58aec4438019853207521a164f4 > Author: Patrick Ohly <[email protected]> > Date: Mon Jul 4 21:05:52 2011 +0200 > > error handling: recognize local errors again > > Commit 3f1185, contained in 1.1.99.3, changed > SyncContext::throwError() so that it throws a StatusException with > STATUS_FATAL. Previously a runtime exception was thrown, which > Exception::handle() recorded as a local error. > > This commit fixes that regression by throwing a STATUS_FATAL + > LOCAL_STATUS_CODE, which restores the traditional result of > throwError(). > > Found by test-dbus.py TestDBusSyncError.testSyncNoConfig. >
Ok, so this is the proper place to do this change. I was doing this in the server on my branch. I've removed that commit now. >> FAIL: master must detect a hanging child >> Sync succeeds although it shouldn't - timing changes? > > commit 083984b1cf1e990f45dc05179f2e9bcd2ff47cda > Author: Patrick Ohly <[email protected]> > Date: Mon Jul 4 21:25:23 2011 +0200 > > D-Bus testing: removed invalid TestLocalSync.testTimeout > > Commit 1a40a29 (added after 1.1.99.4) removed timeouts in the local > transport, reasoning that such timeouts only make sense in unreliable > transports and only cause problems (like premature aborts). > > Therefore the TestLocalSync.testTimeout which tested the old behavior > became invalid. Removed completely. > With these changes, I'm down to only one failure and errors associated to the global property issue. Also, out of curiosity, I rebased me dbus-server-reorganization branch onto master and ran the test. It returns the exact same results as the master branch. So, everything seems to be alright there thus far. Unfortunately, the "same results" means that it also has the defaultPeer issue which I'm trying to find a fix for. Also, feel free to merge or cherry-pick any remaining commits from the test-dbus branch at this point. Cheers, Chris _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
