On Wed, Feb 13, 2013 at 2:54 PM, Thomas H.P. Andersen <pho...@gmail.com> wrote: > On Wed, Feb 13, 2013 at 10:31 PM, Lennart Poettering > <lenn...@poettering.net> wrote: >> On Wed, 13.02.13 12:20, Kok, Auke-jan H (auke-jan.h....@intel.com) wrote: >> >>> >>> On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering >>> <lenn...@poettering.net> wrote: >>> > On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) >>> > wrote: >>> > >>> >> +[Bootchart] >>> >> +#Samples=500 >>> >> +#Freq=25 >>> >> +#Rel=0 >>> >> +#Filter=1 >>> >> +#Output=<folder name, defaults to /var/log> >>> >>> This has changed to /run/log being the default with Harald's patch I >>> merged yesterday. >>> >>> >> +#Init=/path/to/init-binary >>> >> +#Pss=0 >>> > >>> > Hmm, so in systemd so far we tried to avoid abbreviations like this in >>> > exported identifiers. So I'd really prefer if we could use "Frequency" >>> > instead of "Freq" here. Abbreviations and acronyms raise the bar for >>> > newcomers. >>> >>> agreed, as part of this conversion we should just rename these options >>> to Frequency, Relative. >>> >>> > It's not to say we'd never export abbreviations/acronyms anywhere in >>> > systemd, but if we do, then they must be very very well established... >>> >>> Pss, is still an acronym, but Let's keep it that way. >> >> Hmm, what does this stand for? Wikipedia doesn't have it, can't be that >> well known... >> >> Also, if it's an acronym it should probably be PSS not Pss... > > Sent an updated patch with the suggested changes but still Pss.
$ ./systemd-bootchart --help Failed to open configuration file '/etc/systemd/bootchart.conf': No such file or directory Failed to parse configuration file: No such file or directory ... .... I'm not so sure that change actually was helpful - bootchart.conf is entirely optional, so I would actually prefer the old behavior where it doesn't throw log_error() in case the file is missing! > Maybe PSSGraph and EntropyGraph? Btw. we read those two and > Filter/Relative as ints, but they are used as bools. Maybe it would be > clearer if we parse them as such so we can write .e.g. "Relative=no" > in the conf file? that's fine with me, yes please. Auke _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
