On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote:

Looks pretty good. Commented on the invidiaul patches, but mostly looks
good.

I am not sure about the whole approach of making this a potentially
public library though... Especially the monitor stuff sounds so
specific. Commiting to a stable API for that given that there are very
few other projects who could ever make use of this sounds dangerous at
best. Especially since the api exposes bit values for enums and things,
which makes me especially afraid... 

Lennart

-- 
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to