On Thu, 28.11.13 09:08, David Herrmann (dh.herrm...@gmail.com) wrote: > A few comments beforehand: > - regarding logging in libraries: I *want* verbose errors/warnings in > sd-gfx. Especially if modesetting, keymap-compilation or bus-requests > fail, I want some rather verbose messages in the log. Considering that > if a single page-flip fails, I will not abort but continue the modeset > (you don't want your console to abort due to minor timing issues in > the DRM driver, right?), so the application might not even get an > -EXYZ error value. I tried adding a ->log_fn() like libudev, but then
That libudev does that is mostly because it predates log.c, it wouldn't do that either anymore if we'd write it now... > again, sd-gfx is internal so I skipped that and just called log_meta() > directly. Is that fine for now? If not, I can change all these to > log_debug() and make the applications more verbose. > - new0(), zero(), ..., yepp, kay already told me but I forgot.. I will > fix them up. > - moving "out" parameters to the end... will do so. Hmm, interesting problem. I have the suspicion though that this either shouldn't be "library" code, or that they should be downgraded to debug level messages. Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
