Stian Soiland-Reyes wrote: > On Fri, Oct 23, 2009 at 23:59, David Withers > <[email protected]> wrote: >> I've been working on some improvements to the diagram in Taverna. >> Currently when the dataflow, or a layout option, changes a new SVG >> Document is created which is then rendered by the SVG Canvas. As a >> result the view transform is reset each time which resets the zoom level > > I'm currently working on fixing thread leaks in the diagram update > mechanism (T2-912), so if you could hold it for a few days before > committing that would be great. > > We appreciate any effort to improve the diagram, so your change does > sound exciting, I particularly like your animation! > > > About the thread leak, I've fixed it by making the 'Executor' of > SVGGraphController static, and by calling svgCanvas.stopProcessing(); > on workflow result remove / finalize() - but for some reason now the > diagram in the run dialogue has stopped updating until the run is > finished. (Setting the executor back to non-static does not alleviate > it..)
I will have a think about the consequences of making the Executor static - it creates an event queue that is shared by all the diagrams. I'm not sure if that will cause problems or not. > I've also changed the parser plugin for graph-model as it did not want > to compile with the previous version. (Something about escape > characters) - but changing back to the old JAR of this does not make > the diagram update either. I noticed that change - it's an interesting way to convert an Object to a String ;-) David. -- David Withers School of Computer Science, University of Manchester, Oxford Road, Manchester, M13 9PL, UK. +44 (0)161 275 0683 ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ taverna-hackers mailing list [email protected] Web site: http://www.taverna.org.uk Mailing lists: http://www.taverna.org.uk/taverna-mailing-lists/ Developers Guide: http://www.mygrid.org.uk/tools/developer-information
