Stian Soiland-Reyes wrote:
> On Mon, Oct 26, 2009 at 19:34, David Withers
> <[email protected]> wrote:
> 
>> I will have a think about the consequences of making the Executor static
>> - it creates an event queue that is shared by all the diagrams. I'm not
>> sure if that will cause problems or not.
> 
> If we do, we could try to increase the allocated threads to the pool
> (1 at the moment), or make it non-static, but with a good way to stop
> it.

It's implementing a FIFO queue so it can only have one thread processing 
the element at the head of the queue.

>> I noticed that change - it's an interesting way to convert an Object to
>> a String ;-)
> 
> Yeah.. well as far as I could see it would still only set to a String
> in the generated code, but in case something changes (in the syntax
> definition?) I thought better be safe and avoid casting, and instead
> get some interesting results out of "in...@123123" and such. Change it
> to casting if you like :) - you understand the underlying libs a bit
> more than me..

I was thinking more of calling toString() which should only initialise 
one string instead of three (I think). Casting would be less safe 
although I can't imagine that the lexer would return non string token 
images.

I've has a closer look at this seems to be caused by the generated 
SimpleNode (which extends my NamedNode class) also declaring a 'value' 
field which is an Object. I'll fix that.

David.

-- 
David Withers
School of Computer Science, University of Manchester,
Oxford Road, Manchester, M13 9PL, UK.
+44 (0)161 275 0683

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
taverna-hackers mailing list
[email protected]
Web site: http://www.taverna.org.uk
Mailing lists: http://www.taverna.org.uk/taverna-mailing-lists/
Developers Guide: http://www.mygrid.org.uk/tools/developer-information

Reply via email to