On Jul 5, 2005, at 7:30 PM, Michael Richardson wrote:

  oh, a regression test would have shown this.

...and a cleaner implementation of "-A" - i.e., one with a new routine to print out the packet data as ASCII, rather than one that jams that functionality into a routine that does a hex-and-ASCII-dump - wouldn't have had the problem in the first place.

Here's a patch that has separate routines for "-A", "-x", and "-X", and that separately tests Aflag, xflag, and Xflag, and gives them all appropriate names.
-
This is the tcpdump-workers list.
Visit https://lists.sandelman.ca/ to unsubscribe.

Reply via email to