Michael Richardson wrote:
Now, we need to commit the fix :-)
I took that as an indication that I should check in the patch whose URL
I sent to the list; I've checked it into the main and x.9 branches.
There's also the other issue I mentioned:
However, I also noticed that, while "-x" suppresses the default
printing, in the link-layer printers, of packets not printed by any
other routines, "-X" doesn't do so, and never did, as "-X" didn't set
"xflag", it set only "Xflag". "-A" set "xflag", so it suppressed that
default printing; "-A" no longer sets "xflag", so it no longer
suppresses that default printing. I don't know whether it should or
not - "-A" is useful, I suspect, mainly for printing text protocols,
so a hex dump of a non-text protocol might still be useful.
"-X", however, should probably suppress that default printing, just as
"-x" does.
So presumably "-X" should suppress the "print_default()" calls in
link-layer printers (i.e., the
if (!xflag && !qflag)
print_default(...);
calls). I'll look at doing that, unless somebody objects.
Should "-A" do so as well?
-
This is the tcpdump-workers list.
Visit https://lists.sandelman.ca/ to unsubscribe.
