On Jul 5, 2005, at 9:46 PM, dean gaudet wrote:
i also think the 3.9 behaviour needs some slight modifications, so i'vemade two changes on top of your patch Guy.
Well, on top of one of the versions of my patch; it's not the version that got checked in. (I did the original version at work, and tried sending it, but that message was dropped because the attachment was too large. I then redid it at home, and the new version changed things a bit more than the other version did.)
one is to make -AA behave similar to -xx and -XX ... even though it'sprobably never useful it just seemed wrong to test (Xflag > 1) inside theAflag case of your patch.
The version I did at home tested Aflag in that case, so that part of the patch doesn't apply.
further i think that with -A we never want to print the leading tab fromthe "ident" string... otherwise it ends up appearing at quite randomlocations depending on various factors. (another alternative would be toprint the ident string every time we encounter '\n' ...)
In the version I did at home, "ident" isn't even supplied as an argument to "print_ascii()", so that part doesn't apply, either.
the attached patch on top of guy's patch makes these two changes, andincludes a regression test.
The regression tests were already checked in by Michael. - This is the tcpdump-workers list. Visit https://lists.sandelman.ca/ to unsubscribe.
