On Jun 29, 2026, at 2:12 AM, Martin Husemann <[email protected]> wrote: > > On Sun, May 10, 2026 at 02:26:47PM -0700, Chris Hanson wrote: >> Here?s my final updated patch that also ensures the >> posix_spawn_file_actions_addclosefrom_np symbol is appropriately weak, >> guarded by _NETBSD_SOURCE, the libc version is updated, etc. >> > > I still like it :-)
Thanks! > One minor nit: making this visible (in include/spawn.h) only #ifdef > _NETBSD_SOURCE > might not be a good idea. I think it should be visible by default unless > some stricte standard is requested. I wasn’t sure what the rule would be on “NetBSD-only” additions to POSIX-standardized bits. (Even though it’s not really NetBSD-only, and is present on Solaris and Linux and FreeBSD etc.) Isn’t most everything on NetBSD built with _NETBSD_SOURCE set unless specifically built otherwise? (E.g. with POSIX-conformance flags set.) — Chris
