> Date: Mon, 29 Jun 2026 09:12:51 +0000 > From: Martin Husemann <[email protected]> > > One minor nit: making this visible (in include/spawn.h) only #ifdef > _NETBSD_SOURCE might not be a good idea. I think it should be > visible by default unless some stricte standard is requested.
No, it should not be visible by default unless it is part of the oldest C or POSIX standard that we support that has spawn.h, which is to say, if it wasn't in POSIX.1-2001, then it must be guarded. In this case, does not appear in any such standard, so it must be guarded. Users who define, e.g., _POSIX_C_SOURCE=200809L MUST NOT observe the declaration of posix_spawn_file_actions_addclosefrom_np. Note that, if the user doesn't define any feature test macros, they get _NETBSD_SOURCE by default. We can also open it up to other feature test macros like _GNU_SOURCE if useful but that depends on surveying application usage. > If we want this in -11, it has to be commited like *today*. Any > opinions on it? Too late for 11, not worth the risk.
