I haven't caught-up, nor reviewed anything else yet, but comments
inline:
On Tue 2012.11.06 at 16:11 +0100, Thomas Pfaff wrote:
> Can you please provide a unified cvs diff?
'cvs diff -uNp' is best...
> [...]
> > for (iter = 0; iter < nitems(name_to_kbfunc); iter++) {
> > - if (strcmp(name_to_kbfunc[iter].tag, binding) != 0)
> > + if (name_to_kbfunc[iter].tag == NULL ||
> > + strcmp(name_to_kbfunc[iter].tag, binding) != 0)
> > continue;
I too would prefer to use nitems, to be consistent with the rest of the
code. Also reduces the number of gratuitous changes, and of course the
size of the diff.
> > + if ((mi = menu_filter(sc, &menuq, "function", NULL, 0,
> > + search_match_text, NULL)) != NULL) {
> > + func = (struct func *)mi->ctx;
> > + (*func->handler)(cc, &func->argument);
Likewise, as mentioned, consistency with the rest is best.
