> From: [email protected] (=?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges-Anglas?=) > Date: Sat, 04 Apr 2015 18:35:57 +0100 > > Hi, > > just to make things clear, I have no strong opinion towards Philip's > proposal. I merely had kept __BSD_VISIBLE mostly because those > functions had appeared in BSD before they were standardized. Updated > diff, reversing the order of the tests, but not (yet?) suppressing the > __BSD_VISIBLE case.
FWIW, I disagree with Philip. The __BSD_VISIBLE there is useful to remind us that these functions were present in BSD even before POSIX adopted them via System V. > I've been sitting on this for too long, it would be a shame if the > discussion stalled because of a "detail". :) ok kettenis@ > Index: stat.h > =================================================================== > RCS file: /cvs/src/sys/sys/stat.h,v > retrieving revision 1.27 > diff -u -p -p -u -r1.27 stat.h > --- stat.h 8 Dec 2014 20:56:11 -0000 1.27 > +++ stat.h 4 Apr 2015 17:16:27 -0000 > @@ -198,6 +198,10 @@ int mkdir(const char *, mode_t); > int mkfifo(const char *, mode_t); > int stat(const char *, struct stat *); > mode_t umask(mode_t); > +#if __POSIX_VISIBLE >= 200112L || __XPG_VISIBLE >= 420 || __BSD_VISIBLE > +int fchmod(int, mode_t); > +int lstat(const char *, struct stat *); > +#endif > #if __POSIX_VISIBLE >= 200809 > int fchmodat(int, const char *, mode_t, int); > int fstatat(int, const char *, struct stat *, int); > @@ -211,8 +215,6 @@ int futimens(int, const struct timespec > int chflags(const char *, unsigned int); > int chflagsat(int, const char *, unsigned int, int); > int fchflags(int, unsigned int); > -int fchmod(int, mode_t); > -int lstat(const char *, struct stat *); > int isfdtype(int, int); > #endif > __END_DECLS > > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE > >
