On 31/05/16(Tue) 23:55, patrick keshishian wrote: > Hello, > > On Mon, May 30, 2016 at 04:22:56PM +0200, Martin Pieuchot wrote: > > On 26/05/16(Thu) 16:09, patrick keshishian wrote: > > > > > > Included is my initial effort to port the dual-licensed driver > > > for Fushicai Audio-Video Grabber (vendor 0x1b71 product 0x3002). > > > > Nice. Did you test both bulk and iso? Some comments inline. > > As far as I can tell, this device's video streaming endpoint > is isochronous. > > I think I have addressed most of the points you highlighted. > I'll reply inline to each. New diff is inline at the end. I > had to add a rwlock as I hit a race condition testing, where > the bulk thread was accessing variables, as they are being > cleared when the audio client was closing the device. > [...] > Index: ./dev/usb/utvfu_ops.c > =================================================================== > RCS file: ./dev/usb/utvfu_ops.c > diff -N ./dev/usb/utvfu_ops.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ ./dev/usb/utvfu_ops.c 1 Jun 2016 05:45:53 -0000 > @@ -0,0 +1,1440 @@ > +/* $OpenBSD$ */ > +/* > + * Copyright (c) 2008 Robert Nagy <[email protected]> > + * Copyright (c) 2008 Marcus Glocker <[email protected]> > + * Copyright (c) 2016 OpenBSD
This is not correct. ``OpenBSD'' cannot hold any copyright, please put your name and email here, you did the work.
