> Here is a third version that just integrates the coreboot code into
> efifb.  The cnattach path still has to be different to allow vga to
> try to attach before doing the coreboot version.
>
>
> Index: arch/amd64/amd64/efifb.c

> @@ -55,6 +102,8 @@ int         efifb_show_screen(void *, void *, i
>  int   efifb_list_font(void *, struct wsdisplay_font *);
>  int   efifb_load_font(void *, void *, struct wsdisplay_font *);
>  
> +struct cb_framebuffer * cb_find_fb(paddr_t);
                          ^
spurious space.

>  struct cfattach efifb_ca = {
>       sizeof(struct efifb_softc), efifb_match, efifb_attach, NULL
>  };

const.

> @@ -112,7 +161,8 @@ efifb_attach(struct device *parent, stru
>       bus_space_handle_t       ioh;
>       long                     defattr;
>  
> -     printf("\n");
> +     printf(": %dx%d, %dbpp\n", efifb_console.rinfo.ri_width,
> +         efifb_console.rinfo.ri_height, efifb_console.rinfo.ri_depth);

Someone (TM) needs to fix all frame buffer attachments to report
visible geometry and depth in the same way, BTW. This output looks like
tga(4), which is not a good example to follow...

Reply via email to