Hi Alexandr,
On 09.06.2016 22:58, Alexandr Akulich wrote:
Hi George,
It's great to hear about more devs get work on Telepathy.
I'm TelepathyQt maintainer for a year now and I'm planning to release
0.9.7 as soon as I'll made a future-proof commit with fix of
https://bugs.freedesktop.org/show_bug.cgi?id=95376 for Qt-5.8.
It would be helpful if someone would acknowledge or review my changes.
I'm definitely up for that. :)
Since commit [1] there is no QDBusArgument operators overload for
QList. I reported the problem [2] and it seems that the "bad" commit
will be reverted for 5.7, but our current approach is deprecated since
[3].
I'm going to change tools/qt-types-gen.py script to generate such
operators in types-body.hpp:
TP_QT_EXPORT QDBusArgument &operator<<(QDBusArgument &arg, const
UIntList &list)
{
int id = qMetaTypeId<uint>();
arg.beginArray(id);
for (int i = 0; i < list.count(); ++i) {
arg << list.at(i);
}
arg.endArray();
return arg;
}
TP_QT_EXPORT const QDBusArgument &operator>>(const QDBusArgument &arg,
UIntList &list)
{
arg.beginArray();
list.clear();
while (!arg.atEnd()) {
uint item;
arg >> item;
list.append(item);
}
arg.endArray();
return arg;
}
As far as I see, this would be a full equivalent to the current
behaviour, but I didn't fully tested it yet.
Would you acknowledge such approach or I'm missing something
important? Comment in types.h says that we "needed to have a discrete
type in the Qt type system" and we actually do qDBusRegisterMetaType
in types-body.hpp, but at the same time we're relying on QList stream
operators overload, which ignores any T parts except the base and has
no references to the original list object metatype.
As far as I understand, the argument "ignores any T parts except the
base" does not apply to our type here because T is int and int is a
native type that doesn't need further operator overloads. But I can see
how for the generic case it's true.
In any case, I think your approach is sane. Please go ahead and ping me
for a review if you wish.
Regards,
George
[1]
http://code.qt.io/cgit/qt/qtbase.git/commit/?id=5f542f3cca13f2da58b82aee2efbaffefeee00a7
[2] https://bugreports.qt.io/browse/QTBUG-53376
[3]
http://code.qt.io/cgit/qt/qtbase.git/commit/?id=c7d4858c921c7602dc90d56cdd903cd2cb1111c6
On Thu, Jun 9, 2016 at 8:02 PM, George Kiagiadakis
<gkia...@tolabaki.gr> wrote:
Hello all,
For those of you that don't know me, I'm an old kde-telepathy &
telepathy-qt developer who's been inactive in telepathy for a couple
of
years. Recently I've been looking again into what is going on in this
project and it looks like it's dead, which is a pity. However, I can
see
there is some limited activity around telepathy-qt, with some people
writing new Qt-based CMs (cool!). This little activity makes me hope
that maybe it's possible to revive the rest of the project?
I'm basically writing this email to declare my interest in attempting
a
revival. I think free communication is quite important and it's being
neglected a lot recently in the FOSS world, which motivates me enough
to
spend some time again in this project.
As a start, I would like to get in touch with all of you who are still
working on something related to telepathy. It would be nice to start a
conversation about project needs and future plans. So, if you are
interested, please get in touch. I am 'gkiagia' on irc and various
other
places on the internet.
Regards,
George
_______________________________________________
telepathy mailing list
telepathy@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/telepathy
_______________________________________________
telepathy mailing list
telepathy@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/telepathy
_______________________________________________
telepathy mailing list
telepathy@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/telepathy
