Bill Moseley wrote:
On Fri, Dec 23, 2005 at 08:26:41AM -0500, Darren Chamberlain wrote:
But not everyone uses CGI.pm. I agree it's the wrong behaviour,
(although it's rare that I need to use the plugin and not place it in
a href) but it's documented that way and has been for a while. Won't
that break existing code?
I'm using that plugin in a number of projects and expect it to be
already escaped.
Darren Chamerlain wrote:
So I'll add a package global $Template::Plugin::URL::JOINER and have
it default to ';'. Comments?
Bill is correct I think. I would suggest defaulting this to '&'. I've
learned that changing a default behavior that has been around forever is usually
not a good idea.
As another idea, I would also suggest adding this as an argument instead for
people who do not have access to the code.
Something like:
USE url('/foo/bar', {}, {joiner => '&'}); # i've learned hashrefs help when you
want to pass a bunch of options around. otherwise you can end up with 15,000 params
# or if you don't like a hashref for options:
USE url('/foo/bar', {}, '&');
USE url('/foo/bar', {}, '&');
I think whatever you do, though, that you should keep the default behavior that's
been around which is '&' as the joiner. Then we won't break anything, and
people who need to work around this can.
In any case, I've updated CVS, but it's
update to Andy to roll a new release. There are a few other patches
outstanding, so maybe he'll consider another maintainence release soon
(hint, hint).
A "few"? I think I've posted three myself in the last year. ;) I'd love to see
some patches get in. I offered to enter them into CVS myself back in the day, but never
heard back from Andy, so I'm assuming that's a rejection stamp for CVS access. ;)
-- Josh
_______________________________________________
templates mailing list
[email protected]
http://lists.template-toolkit.org/mailman/listinfo/templates
