Hi Rafael,
Rafael Vanoni wrote:
> Hi all
>
> I've made the following changes:
>
> - added the -i option, which implements what we've been talking about
> correlating cyclic events with idle state transitions
Hold on please, I'll take sometime into it.
>
> - allows users with dtrace privileges to run powertop. Root is
> required for suggestions. A message is printed in case a non-priv,
> non-dtrace-able user tries to run the tool
I'm not sure if I missed anything. but what I got seems not to be
correct.
Please see below:
==========================================
[aubrey-monv at amd64]ppriv $$
101969: -bash
flags = <none>
E: basic,dtrace_proc,dtrace_user
I: basic,dtrace_proc,dtrace_user
P: basic,dtrace_proc,dtrace_user
L: all
[aubrey-monv at amd64]./powertop
Solaris PowerTOP 1.0 (C) 2007 Intel Corporation
powertop: C-State DTrace probes unavailable
PowerTOP needs DTrace privileges to run
Please contact your system administrato
==========================================
>
> - chased the few remaining usability bugs. I've (arbitrarily) set a
> upper limit of 100 seconds for measuring interval.
>
> - removed a couple of redundant calls and references to
> suggestions routines
>
>if (!features) {
> printf(_("\n PowerTOP needs DTrace privileges to run\n"));
> printf(_(" Please contact your system administrator\n\n"));
> return -1;
> }
Please don't use this kind of format any longer. Actually I want to
remove all of these format.
It needs libintl, which is missing on other solaris distro.
>------powertop.h--------
>static char cpupm_treshold[] = ...
>------cpufreq.c------
>system(cpupm_treshold);
typo? s/cpupm_treshold/cpupm_threshold/ ?
Thanks,
-Aubrey
