Aubrey Li wrote: > On Tue, Apr 8, 2008 at 9:05 PM, Rafael Vanoni <Rafael.Vanoni at sun.com> > wrote: >> >> - allows users with dtrace privileges to run powertop. Root is >> >> required for suggestions. A message is printed in case a non-priv, >> >> non-dtrace-able user tries to run the tool >> > >> >> You need dtrace_kernel as well. > > Thanks, I got it. > > 1) DTrace privileges message depends on c-state probe firing now, > it could be user missing privileges, and it could be PowerTOP running > on the earlier solaris kernel which doesn't have c-state probe. > So the warning messages depending on features variable seems not to > be good enough, would it be better to check privileges before all statistics > preparing?
Agreed. > 2) if user doesn't running as root, power suggestion will be invisible > forever, > This might not be a good idea. We haven't elaborated on what we'll be doing for suggestions, so I guess this is as far as we can go in terms of allowing a broader range of users to run the tool. > 3) Is it better to tell user how to add dtrace privileges instead of reporting > "Please contact your system administrator?" Well.. the user will have to contact an admin to change his privileges, right? :) thanks Rafael
