Aubrey Li wrote: > Rafael Vanoni<> wrote: >> Yeah, I saw that a couple of hours ago. It's a minor fix at the end of the >> main loop. I'm pushing the fix in a few minutes. >> >> As far as pushing 6834110, if this next push doesn't sell you on the freeze >> option, I'll remove it. >> >> Thanks, >> Rafael > > Thanks for the update. I got the newest fix now. > > More comments about the freezing window feature, in my opinion, when we > want to freeze a sub-window, we want to capture exactly what we are seeing. > But currently when we press "I" and "E" and "F", the sub-window is refreshed > and frozen on the new data. Is this what we want?
That's a good point. The fix for this is also simple, it involves removing this behavior of allowing *any* keystroke to refresh the window and only allowing 'R'. Is that ok with you ? Thanks, Rafael > Thanks, > -Aubrey > >> Aubrey Li wrote: >>> Hi Rafael, >>> >>> Sorry for the delay, please hold on this changeset if it is being put >>> back into ON, >>> Press "I" once, everything works good, I saw the string "I - Idle" in >>> the status window. >>> Press "I" the second time, "I - Idle" is gone, but everything is frozen >>> forever. >>> >>> And I still saw 100% C0 residency. I'll send the screenshot >>> offline(it's larger than the size >>> the mailing list allow), the screenshot is captured when I pressed "I" >>> twice. >>> >>> I don't want you to take much effort on 6836685, for me it's not good >>> enough to put back >>> into ON, Can we put back 6834110 first? ;) >>> >>> Thanks, >>> -Aubrey >>> >>> >>> On Sun, Jun 14, 2009 at 6:34 AM, <rafael.vanoni at sun.com> wrote: >>>> Author: Rafael Vanoni <rafael.vanoni at sun.com> >>>> Repository: /hg/tesla/ptop-full >>>> Latest revision: 70f27d2d4b60bf7ebbae6f9464ba59393b79487d >>>> Total changesets: 1 >>>> Log message: >>>> 6834110 PowerTOP's display.c needs some lovin' >>>> 6836685 PowerTOP should allow the user to freeze its subwindows >>>> >>>> Files: >>>> update: usr/src/cmd/powertop/amd64/pt_amd64.c >>>> update: usr/src/cmd/powertop/common/battery.c >>>> update: usr/src/cmd/powertop/common/cpufreq.c >>>> update: usr/src/cmd/powertop/common/cpuidle.c >>>> update: usr/src/cmd/powertop/common/display.c >>>> update: usr/src/cmd/powertop/common/events.c >>>> update: usr/src/cmd/powertop/common/powertop.c >>>> update: usr/src/cmd/powertop/common/powertop.h >>>> update: usr/src/cmd/powertop/common/suggestions.c >>>> update: usr/src/cmd/powertop/i386/pt_i386.c >>>> update: usr/src/cmd/powertop/sparcv9/pt_sparcv9.c >>>> _______________________________________________ >>>> tesla-dev mailing list >>>> tesla-dev at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/tesla-dev >>>> >>
