Rafael Vanoni<> wrote: > Aubrey Li wrote: >> >> Rafael Vanoni<> wrote: >>>>> >>>>> More comments about the freezing window feature, in my opinion, ?when >>>>> we >>>>> want to freeze a sub-window, we want to capture exactly what we are >>>>> seeing. >>>>> But currently when we press "I" and "E" and "F", the sub-window is >>>>> refreshed >>>>> and frozen on the new data. Is this what we want? >>>> >>>> That's a good point. The fix for this is also simple, it involves >>>> removing >>>> this behavior of allowing *any* keystroke to refresh the window and only >>>> allowing 'R'. Is that ok with you ? >>>> >> >> I personally don't want any of this feature to clobber the original >> powertop behavior. >> But you can make a call. >> >>> In any case, data from the next interval will be very similar to the >>> previous. >>> >> >> No, I don't think so. I actually want to make a screenshot of 100% C0 >> residency in idle >> and want to press "I" to capture the report, but it doesn't work. >> >> You put much effort into this feature and I deeply respect it. Please >> make it well tested >> before putback. >> > > That's cool. I'll remove this CR for the time being, it's taking too much > time for a feature that isn't being sought after. > > Are you ok with leaving the changes to the suggestions and the status bar > and just removing the functionality for the freeze feature? Regardless of > their relationship with the freeze option, I think that code is much better > now. > > Thanks, > Raf
If so, it would be better to decouple it completely. You did a great job recently and powertop is in the much better shape now. I think it's time to release V1.2. :) Thanks, -Aubrey
