[
https://issues.apache.org/jira/browse/THRIFT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606497#action_12606497
]
Craig Kimerer commented on THRIFT-25:
-------------------------------------
While I agree that we should probably handle this (I am leaning towards the
TryGetValue approach), it isn't new with this patch. We should probably make
an issue of it and fix it in a seperate commit.
Other than the patch thinking every line in any modified file is different
(carriage return?), it looks good to me.
> improvements to C# compiler and library
> ---------------------------------------
>
> Key: THRIFT-25
> URL: https://issues.apache.org/jira/browse/THRIFT-25
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#), Library (C#)
> Environment: Windows
> Reporter: Will Palmeri
> Attachments: csharpimprovements.patch
>
>
> We have a patch with lots of changes to the C# compiler and libary.
> Compiler:
> -thrift structures are serializable
> -the member fields of thrift structures are now private and only accessible
> through Properties, which keep the appropriate __isset up to date
> Library
> -addition of TBufferedTransport, which can be used to wrap other Transports.
> I saw a 10x improvement in the test client when using buffered sockets
> -addition of TThreadedServer. manually manages threads instead of relying on
> .net ThreadPool
> -servers use a log delegate. defaults to System.Console, but allows servers
> to use log4net without introducing the dependency.
> ThriftTest visual studio project
> -test client and server that uses ThriftTest.thrift. The project references
> thrift.exe and Thrift.dll from the subversion tree and automatically builds
> generated code. This makes it very easy to test changes in both the compiler
> and library.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
