[
https://issues.apache.org/jira/browse/THRIFT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642237#action_12642237
]
David Reiss commented on THRIFT-25:
-----------------------------------
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=2b4dbd5
Can you take a look at this version? The changes I made were:
- Replacing tabs with spaces in the compiler (but not the library)
- Removing all BOMs.
- Some of the new files were doubled in your uploaded patch (like, it was the
same file concatenated to itself).
> improvements to C# compiler and library
> ---------------------------------------
>
> Key: THRIFT-25
> URL: https://issues.apache.org/jira/browse/THRIFT-25
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#), Library (C#)
> Environment: Windows
> Reporter: Will Palmeri
> Attachments: csharpimprovements-nospace2.patch,
> csharpimprovements.patch
>
>
> We have a patch with lots of changes to the C# compiler and libary.
> Compiler:
> -thrift structures are serializable
> -the member fields of thrift structures are now private and only accessible
> through Properties, which keep the appropriate __isset up to date
> Library
> -addition of TBufferedTransport, which can be used to wrap other Transports.
> I saw a 10x improvement in the test client when using buffered sockets
> -addition of TThreadedServer. manually manages threads instead of relying on
> .net ThreadPool
> -servers use a log delegate. defaults to System.Console, but allows servers
> to use log4net without introducing the dependency.
> ThriftTest visual studio project
> -test client and server that uses ThriftTest.thrift. The project references
> thrift.exe and Thrift.dll from the subversion tree and automatically builds
> generated code. This makes it very easy to test changes in both the compiler
> and library.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
