[
https://issues.apache.org/jira/browse/THRIFT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642274#action_12642274
]
Michael Greene commented on THRIFT-25:
--------------------------------------
I'm not sure how exactly the doubled files happened... strange.
There are some problems with the git version above, including
test/csharp/ThriftTest/Properties/AssemblyInfo is missing an opening "using"
keyword
test/csharp/ThriftTest/Program.cs is "doubled"
I'll look into it further and update with a revised patch, hopefully tonight.
I'd also like to suggest that the Pre-build event in ThriftTest.csproj
reference the C# compiler via an environment variable. Do other C# Thrift
users have an opinion on this? CSHARP_COMPILER? This would make it easier to
build the test project on other platforms.
> improvements to C# compiler and library
> ---------------------------------------
>
> Key: THRIFT-25
> URL: https://issues.apache.org/jira/browse/THRIFT-25
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#), Library (C#)
> Environment: Windows
> Reporter: Will Palmeri
> Attachments: csharpimprovements-nospace2.patch,
> csharpimprovements.patch
>
>
> We have a patch with lots of changes to the C# compiler and libary.
> Compiler:
> -thrift structures are serializable
> -the member fields of thrift structures are now private and only accessible
> through Properties, which keep the appropriate __isset up to date
> Library
> -addition of TBufferedTransport, which can be used to wrap other Transports.
> I saw a 10x improvement in the test client when using buffered sockets
> -addition of TThreadedServer. manually manages threads instead of relying on
> .net ThreadPool
> -servers use a log delegate. defaults to System.Console, but allows servers
> to use log4net without introducing the dependency.
> ThriftTest visual studio project
> -test client and server that uses ThriftTest.thrift. The project references
> thrift.exe and Thrift.dll from the subversion tree and automatically builds
> generated code. This makes it very easy to test changes in both the compiler
> and library.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
