[ 
https://issues.apache.org/jira/browse/THRIFT-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609967#action_12609967
 ] 

Bryan Duxbury commented on THRIFT-42:
-------------------------------------

Option to the java generator sounds good.

I like the idea of generic directives at the whole-file level. I think it would 
give the capabilities that I was thinking about. As far as setting options 
per-entity, what would be hard about it? You'd have to change the grammar to 
accept the "setoption" keyword inside structs/enums/services, and the internal 
object model to have the options map available to the generator. Per field 
would be hard though, I agree.

> javabean generated code assumes camel-case and makes very ugly getters and 
> setters if not camel cased properly
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-42
>                 URL: https://issues.apache.org/jira/browse/THRIFT-42
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>            Priority: Trivial
>
> Let's say you name your fields in underscored lower case (my_cool_field). The 
> bean-style generator only upcases the first character of the name and mashes 
> it onto get, set, etc. You end up with something that looks like 
> "getMy_cool_field". This gross hybrid is pretty terrible. 
> I propose that we either add a case-style compiler option, or at least try 
> and detect the casing and convert it appropriately.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to