[
https://issues.apache.org/jira/browse/THRIFT-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610004#action_12610004
]
David Reiss commented on THRIFT-42:
-----------------------------------
I just remember running into a bunch of snags when we added the docstrings:
rules getting evaluated too early and stuff like that. Although, now that I
think about it, that might have been due to the fact that we were overloading
the comment syntax. One thing to keep in mind is that we should have a
different keyword for whole-file options and struct-specific options.
Otherwise, you don't know how to apply
{noformat}
setopt "foo" "bar"
struct baz { 1: i32 qux; }
{noformat}
I don't see why doing fields would be any harder than doing structures. Just
look at optional and required (which could be made into local options). We
could eliminate the XSD stuff and Erlang's "slist".
> javabean generated code assumes camel-case and makes very ugly getters and
> setters if not camel cased properly
> --------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-42
> URL: https://issues.apache.org/jira/browse/THRIFT-42
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> Let's say you name your fields in underscored lower case (my_cool_field). The
> bean-style generator only upcases the first character of the name and mashes
> it onto get, set, etc. You end up with something that looks like
> "getMy_cool_field". This gross hybrid is pretty terrible.
> I propose that we either add a case-style compiler option, or at least try
> and detect the casing and convert it appropriately.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
