[ 
https://issues.apache.org/jira/browse/THRIFT-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613405#action_12613405
 ] 

Kevin Ballard commented on THRIFT-42:
-------------------------------------

Mostly because I wrote that hunk first, then realized I had to do 'cap_name = 
"_" + cap_name;' to get the second hunk to work cleanly. It doesn't make much 
difference, but maybe it would be better to be consistent and do it the same 
way both times.

> javabean generated code assumes camel-case and makes very ugly getters and 
> setters if not camel cased properly
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-42
>                 URL: https://issues.apache.org/jira/browse/THRIFT-42
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>            Priority: Trivial
>         Attachments: 
> 0001-java-Add-nocamel-option-to-not-CamelCase-field-acce.patch
>
>
> Let's say you name your fields in underscored lower case (my_cool_field). The 
> bean-style generator only upcases the first character of the name and mashes 
> it onto get, set, etc. You end up with something that looks like 
> "getMy_cool_field". This gross hybrid is pretty terrible. 
> I propose that we either add a case-style compiler option, or at least try 
> and detect the casing and convert it appropriately.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to