[
https://issues.apache.org/jira/browse/THRIFT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660881#action_12660881
]
David Reiss commented on THRIFT-25:
-----------------------------------
There are two ways to do it. First, without using Git at all...
- Click the "log" link from that page.
- Look at the log message for the previous commit. It is rev 707213
- Check out a fresh working copy at that revision.
- Click on the "raw" link from my original link.
- Download the patch.
- In your working copy, apply the patch with "patch -p1"
- Make sure to svn add any new files.
- Make your edits.
- svn diff
If you want to use git, either create a clone of the repo
(git://git.thrift-rpc.org/thrift.git), or if you already have one, do a git
fetch to retrieve the latest commits and create a new branch based on mine with
"git checkout -b NAME_OF_NEW_BRANCH 2b4dbd5". Then make your edits and squash
them onto mine with "git commit -a --amend". Finally, you can generate a patch
with "git format-patch HEAD^", or publish to the thrift-rpc.org repo (send me
your ssh public key so I can make an account for you) or any other public git
host (like github) and post the URL.
> improvements to C# compiler and library
> ---------------------------------------
>
> Key: THRIFT-25
> URL: https://issues.apache.org/jira/browse/THRIFT-25
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#), Library (C#)
> Environment: Windows
> Reporter: Will Palmeri
> Attachments: csharpimprovements-nospace2.patch,
> csharpimprovements.patch
>
>
> We have a patch with lots of changes to the C# compiler and libary.
> Compiler:
> -thrift structures are serializable
> -the member fields of thrift structures are now private and only accessible
> through Properties, which keep the appropriate __isset up to date
> Library
> -addition of TBufferedTransport, which can be used to wrap other Transports.
> I saw a 10x improvement in the test client when using buffered sockets
> -addition of TThreadedServer. manually manages threads instead of relying on
> .net ThreadPool
> -servers use a log delegate. defaults to System.Console, but allows servers
> to use log4net without introducing the dependency.
> ThriftTest visual studio project
> -test client and server that uses ThriftTest.thrift. The project references
> thrift.exe and Thrift.dll from the subversion tree and automatically builds
> generated code. This makes it very easy to test changes in both the compiler
> and library.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
