[
https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694802#action_12694802
]
Michael Stockton commented on THRIFT-276:
-----------------------------------------
bq. I'm not wild about this. I don't see the "protocol" suffixes (or for that
matter, the "transport" suffixes") as a really big benefit. I'd much rather see
us use a Thrift::Protocol namespace than focus on ending the names with
Protocol.
I completely understand. I tried to focus on consistency as much as possible.
Although renaming the accelerated protocol to be inline with compact_protocol
and binary_protocol is mostly aesthetic, I figured it would be beneficial down
the road to have a strong convention. If we reach a consensus either way, I'll
be happy.
bq. There's still a bunch of classes in transport.rb and protocol.rb. They look
like reasonable things to keep together (Sockets mostly in transport, and
errors). Was that the idea?
Correct, I kept Socket, for example, in transport.rb because it didn't feel
sensible to have a class named SocketTransport. I can certainly split Socket
and ServerSocket out the way Bryan suggests. We could also consider have a
base.rb file.
> Ruby libraries should have one class per file
> ---------------------------------------------
>
> Key: THRIFT-276
> URL: https://issues.apache.org/jira/browse/THRIFT-276
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Affects Versions: 0.1
> Reporter: Bryan Duxbury
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-276-v2.patch, thrift-276-v3.patch,
> thrift-276.patch
>
>
> There's no reason for so many of our classes to be lumped into the same file.
> For instance, transport.rb contains 9 classes. They may be short, but
> organizationally, it's superior to have separate class files. Of course, some
> files may contain more than one class per file as appropriate - things like a
> protocol and its factory, for instance, are perfectly acceptable to group.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
