[ 
https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694808#action_12694808
 ] 

Bryan Duxbury commented on THRIFT-276:
--------------------------------------

I think it would be cool to have all the transports and their various base 
classes pulled out into separate files. It would certainly ease navigation, and 
make understanding the individual classes hyper-simple. 

> Ruby libraries should have one class per file
> ---------------------------------------------
>
>                 Key: THRIFT-276
>                 URL: https://issues.apache.org/jira/browse/THRIFT-276
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Ruby)
>    Affects Versions: 0.1
>            Reporter: Bryan Duxbury
>            Assignee: Michael Stockton
>            Priority: Trivial
>         Attachments: thrift-276-v2.patch, thrift-276-v3.patch, 
> thrift-276.patch
>
>
> There's no reason for so many of our classes to be lumped into the same file. 
> For instance, transport.rb contains 9 classes. They may be short, but 
> organizationally, it's superior to have separate class files. Of course, some 
> files may contain more than one class per file as appropriate - things like a 
> protocol and its factory, for instance, are perfectly acceptable to group.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to