Hi,

with 1.0.90-20110429 the bug 3290864 http://sourceforge.net/tracker/?func=detail&aid=3290864&group_id=254363&atid=1126848 I reported is fully fixed for me. No keyrepeat problem anymore, the Windows-EXE doesn't crash the standard SLES11SP1 Xvnc anymore, the prebuilt Xvnc Linux binary works fine and also no build problems.

However, as I like to use packages on my servers, I stumbled over a few minor things while building. First, for the release you should update your autotools and run 'autoreconf -fi' (maybe fix the warnings that show up too), otherwise an outdated gettext.m4 will fail to detect glibc NLS support on 64-bit platforms (with --enable-nls), because a pointer is casted to (int). Second, after some thinking I decided to build a tigervnc-Xvnc as a subpackage of the SLES11SP1 xorg-x11-server source RPM. This way I can follow any xserver package updates (security, whatever) easily. Integration required changing tigervnc's build procedure a bit. Instead of copying xserver sources to tigervnc source tree, I copied tigervnc sources into the xserver source tree. This works nicely, but required some minor changes to the tigervnc sources, as you can see in the attached patch. tigervnc-rpm1.patch is a replacement for the mi/miinitext.c part of xserver16.patch (without it some parts of xserver will complain about the missing vncExtensionInit definition during linking). tigervnc-rpm2.patch contains the corresponding change to the tigervnc source.
I hope these 2 can be applied to your repository.

I have an additional hunk for vnc/Makefile.am, but this one is not appropriate for general use (and can also be done via the make invocation, maybe you prepend LIB_DIR with TIGERVNC_ though):
-TIGERVNC_SRCDIR=${top_srcdir}/../..
-LIB_DIR=${top_builddir}/../../common
+TIGERVNC_SRCDIR=${top_srcdir}/tigervnc
+LIB_DIR=${top_builddir}/tigervnc/common

Is there a way turn this into an autoconf option like --enable-tigervnc-within-xserver? I don't know autoconf enough to do that myself.

I can also post the resulting spec-file (or a diff with the changes) if it is considered OK for this list.

Franz
--- mi/miinitext.c.orig 2009-10-12 04:52:40.000000000 +0200
+++ mi/miinitext.c      2011-05-06 16:07:32.000000000 +0200
@@ -271,6 +271,9 @@
 #ifdef COMPOSITE
 extern void CompositeExtensionInit(INITARGS);
 #endif
+#ifdef TIGERVNC
+extern void vncExtensionInit(INITARGS);
+#endif
 extern void GEExtensionInit(INITARGS);
 
 /* The following is only a small first step towards run-time
@@ -438,6 +441,9 @@
 #ifdef XF86BIGFONT
     if (!noXFree86BigfontExtension) XFree86BigfontExtensionInit();
 #endif
+#ifdef TIGERVNC
+    vncExtensionInit();
+#endif
 #if !defined(NO_HW_ONLY_EXTS)
 #if defined(XF86VIDMODE)
     if (!noXFree86VidModeExtension) XFree86VidModeExtensionInit();
--- tigervnc/unix/xserver/hw/vnc/Makefile.am.orig       2011-05-06 
10:28:57.000000000 +0200
+++ tigervnc/unix/xserver/hw/vnc/Makefile.am    2011-05-06 10:29:42.000000000 
+0200
@@ -29,7 +29,7 @@
 
 nodist_Xvnc_SOURCES = fbrop.h fb.h pixman.h
 
-Xvnc_CPPFLAGS = $(XVNC_CPPFLAGS) -DNO_HW_ONLY_EXTS -DNO_MODULE_EXTS 
-UHAVE_CONFIG_H \
+Xvnc_CPPFLAGS = $(XVNC_CPPFLAGS) -DTIGERVNC -DNO_HW_ONLY_EXTS -DNO_MODULE_EXTS 
-UHAVE_CONFIG_H \
        -DXFree86Server -DVENDOR_RELEASE="$(VENDOR_RELEASE)" \
        -DVENDOR_STRING="\"$(VENDOR_STRING)\"" -I$(TIGERVNC_SRCDIR)/common \
        -I$(top_srcdir)/include -I$(includedir)/pixman-1 -I$(includedir)
------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to