On 20/07/2016 11:32, "[email protected] on behalf of sujith h" <[email protected] on behalf of [email protected]> wrote:
>Hi, > > >I had pushed my changes to >http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-i >mport-of-layers-pointing-dir-9911 ><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add- >import-of-layers-pointing-dir-9911> , for review ( first 6 patches ). Hi Sujith, Thanks for this. I don't have access to a build server at the moment, so I have not been able to test building the layer yet. About the UI, I've found a few little things we should look into: * The validation for the layer directory field fires when the directory radio button is selected, which means that when you display the form by selecting the 'directory' radio button there is an error shown. That should not happen * When you import a layer using a directory, the 'import layer' button becomes enabled if you enter a layer directory, without checking whether you have provided a project name. The button should remain disabled until you have entered both the layer directory and the project name * When I try to import a layer using a git repo, the import layer button remains disabled after I have entered all the necessary information (name, git repo and revision). So I cannot import the layer The template markup also needed a bit of tidying up, which I've done in this branch: http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/non- git-layers-ui Please check for spacing issues: I am not using my usual development machine, so I might have messed up some stuff :/ Sorry Cheers, Belén > > >Below are the steps I followed to test it: > >1) started toaster > >2) cloned meta-openembedded from >git://git.openembedded.org/meta-openembedded ><http://git.openembedded.org/meta-openembedded> > >3) removed .git folder from meta-openembedded > >4) from toaster imported meta-openembedded/meta-oe layer, by adding >absolute path mentioned in "Layer directory information" ( click radio >button "In a Directory") > >5) build a small recipe from meta-oe layer, usleep > >6) build was successful. > > > >Let me know if I need to make changes to my patch set, which I would be >happy to do so. > > >Thanks, > >Sujith H > > >-- >സുജിത് ഹരിദാസന് >Bangalore ><Project>Contributor to KDE project > ><Project>Contributor to Yocto project > >http://fci.wikia.com/wiki/Anti-DRM-Campaign ><Blog> http://sujithh.info > >C-x C-c > > > > > > > > > > > > > > > > > > > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
