Hi Belen, Sorry I completely missed sections from page 11 to 16 in the design doc :(
On Wed, Jul 27, 2016 at 4:06 PM, Barros Pena, Belen < [email protected]> wrote: > > > On 26/07/2016 09:27, "sujith h" <[email protected]> wrote: > > >> > >>>Hi, > >>> > >>> > >>>I had pushed my changes to > >>> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add > >>>- > >>>i > >>>mport-of-layers-pointing-dir-9911 > >>>< > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/ad > >>>d > >>>- > >>>import-of-layers-pointing-dir-9911> , for review ( first 6 patches ). > > Hi Sujith, > > I was finally able to build a non-git layer. It builds no problems, but we > have some issues with the build data side: basically, the non-git layer > shows up as "Unidentified layer". As part of this feature, we need to make > sure build information for these layers is recorded correctly. > > I've also found a few additional issues with the functionality: > > * The javascript for the import layer page is creating some trouble: once > the import button becomes enabled once, it never gets disabled again. You > can try this: enter a layer name and a valid path. The "import" button > will become enabled since you have provided all the necessary information. > Then switch the radio button selection to a git repository. The "import" > button is still enabled, even though you have not provided any git > repository information. You can then import a layer with no git repo url > or revision, which will fail to build. > > * I've also noticed the changes specified in pages 11 to 16 of the design > document are not in place. We need those changes as part of this feature: > they are small things, but important to keep Toaster coherent. > > * Thanks for creating the second version of the existing layer name > message. The content looks ok, but the links to the layer details page > don't go anywhere. Their href attribute seems to be empty. > > Thanks!! > > Belén > > >> > > -- സുജിത് ഹരിദാസന് Bangalore <Project>Contributor to KDE project <Project>Contributor to Yocto project http://fci.wikia.com/wiki/Anti-DRM-Campaign <Blog> http://sujithh.info C-x C-c
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
