Hi Sujith, Excellent progress :) We are nearly there, but it looks like we are still missing some bits and pieces of build information. All details in line
On 27/07/2016 11:36, "Barros Pena, Belen" <[email protected]> wrote: > > >On 26/07/2016 09:27, "sujith h" <[email protected]> wrote: > >>> >>>>Hi, >>>> >>>> >>>>I had pushed my changes to >>>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/ad >>>>d >>>>- >>>>i >>>>mport-of-layers-pointing-dir-9911 >>>><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/a >>>>d >>>>d >>>>- >>>>import-of-layers-pointing-dir-9911> , for review ( first 6 patches ). > >Hi Sujith, > >I was finally able to build a non-git layer. It builds no problems, but we >have some issues with the build data side: basically, the non-git layer >shows up as "Unidentified layer". As part of this feature, we need to make >sure build information for these layers is recorded correctly. The "Unidentified layer" is gone, but some information related to my non-git layer is missing from the build data pages. This is what I did. I cloned meta-raspberrypi (git://git.yoctoproject.org/meta-raspberrypi) and imported it as meta-mypi pointing to /home/belen/meta-mypi Then I built one of the recipes provided by the layer (rpi-config). The build completes, but: * meta-mypi is not listed in the list of layers used in the build * rpi-config is not listed in the table of recipes built Interestingly, the rpi-config packages are listed in the table of packages built, and I can see the layer information (meta-mypi), the 'not applicable' message for the layer branch and commit columns (nicely done), and the recipe providing the package (meta-mypi). >From there I can access the recipe details page for rpi-config and all the information is there (including the recipe file pointing to home/belen/meta-mypi/recipes-bsp/bootfiles/rpi-config_git.bb, which is neat). I can also see rpi-config listed in the list of compatible software recipes and in the layer details page for meta-mypi. So we are nearly there! We just need to make sure the non-git layer is listed in: * The build dashboard * The Configuration page in the build data And that the recipes from the non-git layer are listed in the Recipes table in the build data. > >I've also found a few additional issues with the functionality: > >* The javascript for the import layer page is creating some trouble: once >the import button becomes enabled once, it never gets disabled again. You >can try this: enter a layer name and a valid path. The "import" button >will become enabled since you have provided all the necessary information. >Then switch the radio button selection to a git repository. The "import" >button is still enabled, even though you have not provided any git >repository information. You can then import a layer with no git repo url >or revision, which will fail to build. This seems to be behaving properly now. Thanks! > >* I've also noticed the changes specified in pages 11 to 16 of the design >document are not in place. We need those changes as part of this feature: >they are small things, but important to keep Toaster coherent. This is also in place. Thank you! > >* Thanks for creating the second version of the existing layer name >message. The content looks ok, but the links to the layer details page >don't go anywhere. Their href attribute seems to be empty. I am still seeing this with the latest changes. The links to the layer details page in the message have an empty href attribute when the existing layer points to a directory. The links are ok when the existing layer points to a git repository. > >Thanks!! > >Belén > >>> > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
