----- Original Message -----
From: "Craig R. McClanahan" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Monday, February 25, 2002 6:25 PM
Subject: Re: [PATCH] MinimalTomcat, Coupling, Bugs 6669, 6670


> An additional, more subtle, cross-package dependency is probably also
> there -- assumptions about the implemented functionality, or the expected
> order of method calls, that might not always be clearly stated in the
> method JavaDocs.  We'll want to review the code for these kinds of cases
> as well.

This is the one that really bit me in porting ApacheConfig to 4.x.  And, as
a result, the 4.x ApacheConfig suffers from the same problem of making
assumptions about the order of method calls.  Saying that they might "not
always be clearly stated in the method JavaDocs" is a gross understatement.
Roughly half the time, the "start" event is fired at the beginning (allowing
Listeners to change the config), and half the time it is fired at the end
(allowing Listeners to react to the config).  IMHO, the 3.3 event model is
an improvement: where you have an "init" event (fired at the beginning of
the start method), and a "start" event (fired at the end of the start
method).

As I said, this is IMHO.  Attempts to start a flame-war will be quietly
ignored.

>
> >
> >  In any case, tomorrow I'll whip up a sourceball of the
> > current MinimalTomcat code and stick it out on the net
> > somewhere.
> >
> >
>
> I'd like to see what you've done so far.
>
> Craig
>
>
> > --
> > Christopher St. John [EMAIL PROTECTED]
> > DistribuTopia http://www.distributopia.com
> >
> > --
> > To unsubscribe, e-mail:
<mailto:[EMAIL PROTECTED]>
> > For additional commands, e-mail:
<mailto:[EMAIL PROTECTED]>
> >
> >
>
>
> --
> To unsubscribe, e-mail:
<mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail:
<mailto:[EMAIL PROTECTED]>
>


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to