James Carlson wrote:
Dan Price writes:
        http://cr.grommit.com/~dp/webrev.1/

Interesting ...

Two suggestions (besides the ones others have mentioned):

  - Not wild about frames, but on the frames diff, it'd be nice to
    place the delta comments outside of the scrolling area.  That
    probably shouldn't scroll away.  (Or at least shouldn't scroll
    with the code.)

  - It'd be nice to be able to generate webrevs that can be placed on
    grommit.  I always have to hack away at the generated html to fix
    references to CRs and ARC materials, and it'd be nice if I could
    just tell webrev "make one for the world."


WEBREV_BUGURL="http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id="; webrev -w
(apologies for the awful way that's probably going to wrap).

Will fix up the CR references, there isn't an equivalent for ARC materials, but given they're so unlikely to be accessible, there's no real reason to worry.

A flag to do similar automatically would certainly be a good thing (an even better thing would be moving to a point where it doesn't need to be a flag, because everyone gets the same view... I can dream, right?) :)

-- Rich.
_______________________________________________
tools-discuss mailing list
[email protected]

Reply via email to